-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add report percentages to dashboard and details view #5923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
f11a50c to
bd04d96
Compare
939409c to
09f0011
Compare
- Enable horizontal scroll for details modal on mobile - Add responsive spacing and positioning to modal
09f0011 to
5360b49
Compare
- This isn't needed anymore since we now handle the tooltip logic in the MetricValue component
680d2dc to
8628a99
Compare
…ard, and show on hover in detailed view
- Unlike percentages, CR should show permanently.
fe9b493 to
53b4bdf
Compare
741cd5e to
db70e69
Compare
| percentage: | ||
| fragment( | ||
| "if(? > 0, round(? / ? * 100, 1), null)", | ||
| "if(? > 0, round(? / ? * 100, 2), null)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: If we include another digit, it implies that it's a meaningful digit. Is our tracking accuracy really at this level? Let's say we show the value of 50.04%. Is the true value (assuming perfect tracking) in the range 50.03% ... 50.05% or more like 50.0% ... 50.1%?
I'm also concerned that historical stats API requests would start yielding slightly different values, which may cause frustration when compared with previously requested data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason this was introduced is because there's often a long tail of <0.1% items. Rather than showing 0% for all of these, we'd like to show 0.05%, 0.06%, etc. So in the majority of cases we don't care about the second decimal, only for numbers below 0.1.
| "scroll_depth" => nil, | ||
| "name" => "/some-other-page" | ||
| "name" => "/some-other-page", | ||
| "percentage" => 300.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue, blocking: something seems to be off when we consider imported data in our calculations. Perhaps its a separate bug and a matter for another time, but I think it may be surprising to customers to see this sort of values.
- Update tests to expect correct percentages (≤100%) when imported data is included. These tests will fail until the percentage calculation bug is fixed, documenting the expected behavior.
Changes
Detailsbutton when all items are visible on the dashboard, so the detailed breakdown can be viewed at all times.CleanShot.2025-12-11.at.13.27.17.mp4
Tests
Changelog
Documentation
Dark mode