fix: Fix CI failures with pnpm 10.#3
Merged
Merged
Conversation
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
mcollina
requested changes
May 13, 2026
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
node 20 is out of the EOL, we need a different update.
Contributor
Author
|
Can you please expand? |
Contributor
Author
|
The thing is that this package is only needed for Node 20 now, all other version have it inside process. |
Member
|
It's currently depended on by wattpm 2 which we still support, which supports Node.js 20. |
Contributor
Author
|
Sure, I get that. What is the problem with the fix I made? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates CI to exercise Node.js 20 with pnpm 10, regenerates the pnpm lockfile where needed, and records approved dependency build scripts for pnpm 10.