Skip to content

Cluster size is required for keyspace create #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscoutermarsh merged 2 commits into from
Feb 17, 2026
Merged

Cluster size is required for keyspace create #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45f309a
Cluster size is required for keyspace create
mscoutermarsh Feb 17, 2026
102ab11
lint fixes
mscoutermarsh Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/cmd/keyspace/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func CreateCmd(ch *cmdutil.Helper) *cobra.Command {
},
}
cmd.Flags().IntVar(&flags.shards, "shards", 1, "Number of shards in the keyspace")
cmd.Flags().StringVar(&flags.clusterSize, "cluster-size", "PS-10", "cluster size for the keyspace. Use `pscale size cluster list` to get a list of valid sizes.")
cmd.Flags().StringVar(&flags.clusterSize, "cluster-size", "", "cluster size for the keyspace. Use `pscale size cluster list` to get a list of valid sizes.")
cmd.Flags().IntVar(&flags.additionalReplicas, "additional-replicas", 0, "number of additional replicas per shard. By default, each production cluster includes 2 replicas.")
cmd.Flags().BoolVar(&flags.wait, "wait", false, "Wait until the keyspace is ready")

Expand Down
20 changes: 10 additions & 10 deletions internal/cmdutil/completions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,26 +51,26 @@ func ClusterSizesCompletionFunc(ch *Helper, cmd *cobra.Command, args []string, t

if *c.Rate > 0 {
if description.Len() > 0 {
description.WriteString(fmt.Sprintf(" · $%d/month", *c.Rate))
fmt.Fprintf(&description, " · $%d/month", *c.Rate)
} else {
description.WriteString(fmt.Sprintf("$%d/month", *c.Rate))
fmt.Fprintf(&description, "$%d/month", *c.Rate)
}
}

if c.CPU != "" {
if description.Len() > 0 {
description.WriteString(fmt.Sprintf(" · %s vCPUs", c.CPU))
fmt.Fprintf(&description, " · %s vCPUs", c.CPU)
} else {
description.WriteString(fmt.Sprintf("%s vCPUs", c.CPU))
fmt.Fprintf(&description, "%s vCPUs", c.CPU)
}
}

if c.Memory > 0 {
description.WriteString(fmt.Sprintf(" · %s memory", FormatParts(c.Memory).IntString()))
fmt.Fprintf(&description, " · %s memory", FormatParts(c.Memory).IntString())
}

if c.Storage != nil && *c.Storage > 0 {
description.WriteString(fmt.Sprintf(" · %s storage", FormatPartsGB(*c.Storage).IntString()))
fmt.Fprintf(&description, " · %s storage", FormatPartsGB(*c.Storage).IntString())
}

clusterSizes = append(clusterSizes, cobra.CompletionWithDesc(ToClusterSizeSlug(c.Name), description.String()))
Expand Down Expand Up @@ -114,19 +114,19 @@ func BranchClusterSizesCompletionFunc(ch *Helper, cmd *cobra.Command, args []str
var description strings.Builder
description.WriteString(c.DisplayName)
if *c.Rate > 0 {
description.WriteString(fmt.Sprintf(" · $%d/month", *c.Rate))
fmt.Fprintf(&description, " · $%d/month", *c.Rate)
}

if c.CPU != "" {
description.WriteString(fmt.Sprintf(" · %s vCPUs", c.CPU))
fmt.Fprintf(&description, " · %s vCPUs", c.CPU)
}

if c.Memory > 0 {
description.WriteString(fmt.Sprintf(" · %s memory", FormatParts(c.Memory).IntString()))
fmt.Fprintf(&description, " · %s memory", FormatParts(c.Memory).IntString())
}

if c.Storage != nil && *c.Storage > 0 {
description.WriteString(fmt.Sprintf(" · %s storage", FormatPartsGB(*c.Storage).IntString()))
fmt.Fprintf(&description, " · %s storage", FormatPartsGB(*c.Storage).IntString())
}

clusterSizes = append(clusterSizes, cobra.CompletionWithDesc(c.Name, description.String()))
Expand Down