Skip to content

Support Faraday 1.0+, fix issue with non-raised server errors (50X) #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smudge wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Support Faraday 1.0+, fix issue with non-raised server errors (50X) #316

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
151dcc8
Fix issue with non-raised server errors (5XX)
smudge Feb 9, 2021
cf2b5ea
Merge branch 'master' into patch-1
smudge Mar 2, 2021
9ef222b
Merge branch 'master' into patch-1
smudge Mar 3, 2021
07a9f89
Merge branch 'master' into patch-1
smudge Mar 22, 2021
bd86cd6
Merge branch 'master' into patch-1
smudge Apr 19, 2021
61a0e6b
Merge branch 'master' into patch-1
smudge May 18, 2021
48c1bb7
Merge branch 'master' into patch-1
smudge May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/plaid/middleware.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ class Middleware < ::Faraday::Response::Middleware

# Internal: Default read timeout for HTTP calls in seconds.
NETWORK_TIMEOUT = 600
# Internal: Status codes recognized as client or server errors.
ERROR_STATUSES = 400...600

def on_complete(env)
return unless Faraday::Response::RaiseError::ClientErrorStatuses
.include?(env[:status])
return unless ERROR_STATUSES.include?(env[:status])

error_class = Plaid::Error.error_from_type(env.body['error_type'])

Expand Down