more info in shell scripts.#27
Conversation
| # if [ "${DEVEL_RELEASE-}" = 1 ]; then | ||
| # nightly build steps | ||
| # else | ||
| # regular build steps | ||
| # fi | ||
| # echo "Installing from source..." | ||
| # echo "---------------------------------------------------------------" | ||
| # git clone https://gitlab.com/guillermop/master-key.git source && ( | ||
| # cd ./source | ||
| # #Setiing Application Version for sharun. | ||
| # TAG=$(git tag --sort=-v:refname | grep -vi 'rc\|alpha' | head -1) | ||
| # git checkout "$TAG" | ||
| # echo "$TAG" > ~/version | ||
| # # Building | ||
| # meson setup build --prefix=/usr | ||
| # meson compile -C build | ||
| # meson install -C build | ||
| ) |
There was a problem hiding this comment.
These instructions are too specific to be added to the template.
When you have to build a project manually the steps really differ depending on the build system, not everything uses meson.
So please revert this part.
You also removed the example of if [ "${DEVEL_RELEASE-}" = 1 ]; then which is very important here, this is needed when you want to make separate nightly and stable releases
| VERSION=$(pacman -Q PACKAGENAME | awk '{print $2; exit}') # example command to get version of application here | ||
| export ARCH VERSION | ||
| export ARCH | ||
| # Used by sharun to set x86_64 or aarch64 in appimage name |
There was a problem hiding this comment.
do we really need to specify this lol
I don't think anything regarding ARCH and VERSION needs to be changed here btw
| # example command to get version of application here | ||
|
|
||
| export OUTPATH=./dist | ||
| # Where sharun will store the appimage |
There was a problem hiding this comment.
Do we really need to state this, the variable name should be good enough already.
| export STARTUPWMCLASS=ext.website.appname | ||
| export GTK_CLASS_FIX=1 |
There was a problem hiding this comment.
This cannot be enabled by default
| export ICON=PATH_OR_URL_TO_ICON | ||
| # Path or URL to an icon file to include. | ||
|
|
||
| export DESKTOP=PATH_OR_URL_TO_DESKTOP_ENTRY | ||
| # Path or URL to a .desktop file to include. |
There was a problem hiding this comment.
Do we really need these comments
In the template it gets set as PATH_OR_URL_TO_DESKTOP_ENTRY already, which tells you what it does.
| # export DEPLOY_BABL=1 | ||
| # Set to 1 to force deployment of babl. | ||
| # export DEPLOY_GDK=1 | ||
| # Set to 1 to force deployment of gdk-pixbuf. | ||
| # export DEPLOY_GEGL=1 | ||
| # Set to 1 to force deployment of GEGL. | ||
| # export DEPLOY_GLYCIN=1 | ||
| # Set to 1 to force deployment of Glycin. | ||
| # export DEPLOY_IMAGEMAGICK=1 | ||
| # Set to 1 to force deployment of ImageMagick. | ||
| # export DEPLOY_LIBHEIF=1 | ||
| # Set to 1 to force deployment of libheif. |
There was a problem hiding this comment.
These do not need to be mentioned, since they should be enabled automatically when needed.
| #------------------------ | ||
| # Media Playback | ||
| #------------------------ | ||
| # export DEPLOY_GSTREAMER=1 | ||
| # export DEPLOY_GSTREAMER_ALL=1 | ||
| # Set to 1 to force deployment of GStreamer. By default | ||
| # several gstreamer plugins are removed, set DEPLOY_GSTREAMER_ALL=1 | ||
| # if you can to deploy ALL Gstreamer plugins. (Very bloated). |
There was a problem hiding this comment.
These do not need to be mentioned, since they should be enabled automatically when needed.
the only exception is DEPLOY_GSTREAMER_ALL=1 which we have never needed in reality so far
|
I think we should put the link to the docs as a comment and only add small comments here when needed. To me, this looks cluttered. |
|
yeah I came to the same idea its to cluttered when I I was overthinking stuff trying to go to sleep(brain needs to shut up when I need sleep), got a different idea, ill post in a bit. |
To help new people find documentation.
|
Ok nuked my old submission with a new way. I made a documentation folder and put all my stuff in there. As people build things they can add examples. Anything that you think people will be like how do i do this, let me go search for 30 minutes to find a answer. Also there is documentation? Been winging it.... |
Looks better than before, will check in more detail sometime later
It's this link: |
3 participants
Added more information on...
Might have stopped me from fumbling around so much.