feat: merge my pg_interval_2 fork into mainline#78
Open
sunng87 wants to merge 34 commits intopiperRyan:masterfrom
Open
feat: merge my pg_interval_2 fork into mainline#78sunng87 wants to merge 34 commits intopiperRyan:masterfrom
sunng87 wants to merge 34 commits intopiperRyan:masterfrom
Conversation
feat: add parse_sql for interval
feat: implement postgres_verbose
feat: implement Error for ParseError
feat: resolve several postgres style roundtrip issues
feat: from_postgres_verbose
fix: iso format
fix: correct to_sql format
sunng87
commented
Feb 5, 2026
piperRyan
reviewed
Feb 14, 2026
src/interval_fmt/sql.rs
Outdated
| false, | ||
| ); | ||
| format!("{} {:+} {}", year_month, self.days, time_interval) | ||
| let has_negative = self.years < 0 |
Owner
There was a problem hiding this comment.
suggestion: let's introduce a helper function like is_zeroed to make this a bit and other sections a bit more readable.
Collaborator
Author
There was a problem hiding this comment.
Updated to reuse some helper functions. Also cache the results to avoid duplicated compute.
Collaborator
Author
|
Sorry for massive delay. I have updated patch to address comments and conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fork includes features: