Fix image tracking for initContainers and CronJob containers#6552
Open
zyzzmohit wants to merge 1 commit intopipe-cd:masterfrom
Open
Fix image tracking for initContainers and CronJob containers#6552zyzzmohit wants to merge 1 commit intopipe-cd:masterfrom
zyzzmohit wants to merge 1 commit intopipe-cd:masterfrom
Conversation
…erImages This commit fixes an issue where 'FindContainerImages' only searched within 'spec.template.spec.containers.image', causing initContainers and scheduled job containers to be left out of image tracking. By traversing 'initContainers' and 'jobTemplate.spec', images in these contexts are now correctly tracked. Fixes pipe-cd#6528 Signed-off-by: zyzzmohit <mohitray949@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: Updates FindContainerImages to correctly extract and track images from initContainers and CronJob specifications.
Why we need it: Currently, FindContainerImages only traverses spec.template.spec.containers.image. This limitation causes deployments containing initContainers or batch CronJob workloads to have their images completely ignored during tracking and manifest analysis. This PR expands the AST traversal to capture those missing layers.
Which issue(s) this PR fixes: Fixes #6528
Does this PR introduce a user-facing change?:
How are users affected by this change: Image tracking and drift detection will now accurately reflect initContainers and CronJob images, providing a complete view of the deployed workload.
Is this breaking change: No
How to migrate (if breaking change): N/A