Integrate Slice Sampling: Covariance Matching MCMC#896
Integrate Slice Sampling: Covariance Matching MCMC#896lorcandelaney wants to merge 14 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #896 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 66 67 +1
Lines 7052 7180 +128
==========================================
+ Hits 7052 7180 +128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ben18785
left a comment
There was a problem hiding this comment.
Very readable code -- nice work! I've suggested a few (very minor) changes. I can't see where this code deviates from what is written. The only thing I'm unsure about is whether ask / tell returns the gradient or negative gradient and if F and R need to be transposed (as this is the last part of your chud function).
Can you add an example notebook here that shows the issue? I couldn't find one.
|
Sorry it's a different method isn't it? |
|
Is this ready for re-review @ben18785 ? |
See #772
Includes: