Use Effect schema decoders for JSON parsing#3060
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Contributor
|
🚀 Expo continuous deployment is ready!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
.t3code/vcs.jsonwith a hoistedSchema.fromJsonStringdecoder and useOptioninstead of null sentinels for parse/config-path absence.Schema.fromJsonStringdecoders instead ofJSON.parseplus ad-hoc record traversal.assertwith explicit union narrowing, and added malformed VCS config coverage.Why
These are small idiomatic Effect improvements that keep parsing behavior schema-driven, make invalid data handling explicit, and preserve the existing fallback/rejection behavior with focused tests.
UI Changes
None.
Checklist
Validation:
vp test run packages/shared/src/dpop.test.ts apps/server/src/vcs/VcsProjectConfig.test.ts-> 2 files / 9 tests passedvp check-> passed (printed unrelated existing warnings inapps/web/src/components/ChatMarkdown.tsx)vp run typecheck-> passedNote
Use Effect Schema decoders for JSON parsing in DPoP verification and VCS config
JSON.parseand manual type guards with EffectSchema-based decoders indpop.tsandVcsProjectConfig.tsDpopJwtHeaderPublicJwkschema that forbids private key material and enforces JWK shape, plus strict literal checks fortypandalgfieldsverifyDpopProofnow returns'Invalid DPoP JWT header.'or'Invalid DPoP JWT payload.'instead of a generic'Invalid DPoP proof.'when schema validation failsOption-based decoding; invalid or malformed config JSON falls back to'auto'with a warning log instead of throwingverifyDpopProoffailure reason strings will see more specific messages for malformed inputsMacroscope summarized be97795.