Make SSH Effect usage more idiomatic#2930
Closed
cursor[bot] wants to merge 3 commits into
Closed
Conversation
Member
|
@cursor please rebase this on latest origin/main! |
Contributor
Author
|
Now let me update the PR:The branch has been successfully rebased onto latest
|
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
…h Schema.is guard After rebase on main, the SSH error schema definitions needed updating: - Schema.Defect must be called as Schema.Defect() (function invocation) - Added stdout field to SshCommandError schema to match main's error construction - Replaced instanceof SshHttpBridgeError with Schema.is guard in desktop IPC Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
c66a839 to
f42b293
Compare
Contributor
|
🚀 Expo continuous deployment is ready!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What Changed
@t3tools/ssherror classes fromData.TaggedErrorto schema-backedSchema.TaggedErrorClassdefinitions and added SSH error union schemas.instanceofchecks with hoistedSchema.isguards and added focused coverage for serializable SSH errors.Why
This keeps the SSH package aligned with idiomatic Effect practices: native
Durationvalues flow into timeout/schedule/process APIs, and tagged errors now have structured schemas for serialization and schema-aware narrowing.UI Changes
Not applicable; no UI changes.
Checklist
Note
Replace
instanceofchecks and numeric millisecond timeouts with EffectDurationand schema-based predicates in SSH packagespackages/ssh/src/errors.tsfromData.TaggedErrortoSchema.TaggedErrorClass, making them encodable/decodable and checkable viaSchema.isinstead ofinstanceof.Durationconstants throughoutpackages/ssh/src/tunnel.tsandpackages/ssh/src/command.ts; effective timeout durations are unchanged.timeout?: Duration.Inputfield toRunSshCommandOptionsandwaitForHttpReady, deprecating the old*Msnumeric fields while retaining backwards compatibility.instanceofchecks against SSH error classes may need to switch toSchema.is-based predicates.Macroscope summarized c66a839. (Automatic summaries will resume when PR exits draft mode or review begins).