Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved This change adds Nerd Font fallbacks to the terminal's font-family CSS property while preserving all existing fonts in order. It's a purely cosmetic change to support better glyph rendering, with no runtime behavior impact. You can customize Macroscope's approvability policy. Learn more. |
443d780 to
044970f
Compare
What changed
Adds a named terminal font-family stack for the thread terminal that preserves the existing default fonts first, then adds common Nerd Font fallbacks before the final generic
monospacefallback.This keeps the current default appearance where
SF Mono,Consolas,Liberation Mono, orMenlowork, while allowing Powerline/Nerd Font prompt glyphs to render when an installed Nerd Font can cover missing glyphs.Closes #1918.
Why
The integrated terminal currently ends its fixed font stack at generic
monospace. On Linux, shell prompts that use Nerd Font or Powerline glyphs can render as boxes/unknown characters even when a compatible Nerd Font is installed.This is intentionally not a configurable terminal-font setting. PR #1572 was closed because a broader appearance system is planned; this PR only adds fallback fonts to the existing stack.
UI notes
Before, prompt glyphs render as boxes/unknown characters:
After, installed Nerd Font fallbacks cover the prompt glyphs:
The screenshots are cropped to show only the terminal prompt area.
Validation
bun fmtbun lintpasses with one existingeslint-plugin-unicorn(consistent-function-scoping)warning inapps/web/src/environments/runtime/catalog.test.tsbun typecheckpasses with Bun 1.3.9 and Node 24.13.1Note
Add Nerd Font fallbacks to the terminal font family list
Extracts the xterm
fontFamilyoption into aTERMINAL_FONT_FAMILYconstant in ThreadTerminalDrawer.tsx, expanding the fallback list to include common Nerd Font variants alongside existing monospaced defaults.Macroscope summarized 044970f.
Note
Low Risk
Low risk UI-only change that adjusts the xterm
fontFamilystack; no behavior, data, or security logic is modified.Overview
Updates the integrated thread terminal to use a shared
TERMINAL_FONT_FAMILYconstant and expands the font fallback stack to include common Nerd Font variants (while keeping the existing default fonts first), improving rendering of Powerline/Nerd Font prompt glyphs when those fonts are installed.Reviewed by Cursor Bugbot for commit 044970f. Bugbot is set up for automated code reviews on this repo. Configure here.