Fix Windows source startup script runners#1901
Fix Windows source startup script runners#1901RonWelWork wants to merge 6 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved This is a straightforward dev environment fix that changes the TypeScript runner from bun to tsx for Windows compatibility. Changes are limited to a dev script, adding a dependency, and a regression test. No production runtime behavior is affected. You can customize Macroscope's approvability policy. Learn more. |
|
we don't use node 22 so the running ts files doens't apply |
|
Good catch. I checked this against supported Node 24, and you're right that the root I narrowed the patch to the Windows
The remaining issue I was targeting is that the current Windows server dev path goes through Bun, and that fails before normal app use because Bun PTY support is unavailable there. |
Dismissing prior approval to re-evaluate cb3251d
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3d802cb. Configure here.
|
Addressed both Cursor Bugbot notes in the latest push:
Re-ran:
|

Summary
This PR is now narrowed to the Windows
apps/serverdev startup issue.On Windows, the current
apps/serverdev script runsbun run src/bin.ts. That path fails before normal app use because Bun does not support the PTY-backed server runtime there.Changes
apps/serverdevfrombun run src/bin.tstotsx src/bin.tsbuildunchangedVerification
bunx vitest run scripts/package-scripts.test.tsbun fmtbun lintbun typecheckscripts/dev-runner.tsruns under supported Node 24, so the root package-script changes from the earlier revision were removedContext
This is intended as a narrow Windows source/dev fix for the server runtime path only.
Note
Fix Windows compatibility of the apps/server dev startup script
bun run src/bin.tswithtsx src/bin.tsin thedevscript of apps/server/package.json, fixing startup on Windows wherebunis not reliably available.tsx ^4.20.6as a dependency and updates the lockfile accordingly.devscript usestsxto prevent regressions.Macroscope summarized 675b82f.
Note
Low Risk
Low risk change limited to the
apps/serverdevelopment entrypoint and tooling dependency, plus a small test to prevent script regressions.Overview
Updates
apps/serverdevelopment startup to run viatsxinstead ofbun, improving Windows compatibility for local dev.Adds
tsxas a dev dependency (and updates the lockfile) and introducesscripts/package-scripts.test.tsto assert the serverdevscript remainstsx src/bin.tsgoing forward.Reviewed by Cursor Bugbot for commit 675b82f. Bugbot is set up for automated code reviews on this repo. Configure here.