Skip to content

Fix Windows source startup script runners#1901

Open
RonWelWork wants to merge 6 commits intopingdotgg:mainfrom
RonWelWork:codex/get-running
Open

Fix Windows source startup script runners#1901
RonWelWork wants to merge 6 commits intopingdotgg:mainfrom
RonWelWork:codex/get-running

Conversation

@RonWelWork
Copy link
Copy Markdown

@RonWelWork RonWelWork commented Apr 10, 2026

Summary

This PR is now narrowed to the Windows apps/server dev startup issue.

On Windows, the current apps/server dev script runs bun run src/bin.ts. That path fails before normal app use because Bun does not support the PTY-backed server runtime there.

Changes

  • switch apps/server dev from bun run src/bin.ts to tsx src/bin.ts
  • keep build unchanged
  • add a focused regression test covering the server dev runtime expectation

Verification

  • bunx vitest run scripts/package-scripts.test.ts
  • bun fmt
  • bun lint
  • bun typecheck
  • confirmed separately that scripts/dev-runner.ts runs under supported Node 24, so the root package-script changes from the earlier revision were removed

Context

This is intended as a narrow Windows source/dev fix for the server runtime path only.

Note

Fix Windows compatibility of the apps/server dev startup script

  • Replaces bun run src/bin.ts with tsx src/bin.ts in the dev script of apps/server/package.json, fixing startup on Windows where bun is not reliably available.
  • Adds tsx ^4.20.6 as a dependency and updates the lockfile accordingly.
  • Adds a test in scripts/package-scripts.test.ts that asserts the dev script uses tsx to prevent regressions.

Macroscope summarized 675b82f.


Note

Low Risk
Low risk change limited to the apps/server development entrypoint and tooling dependency, plus a small test to prevent script regressions.

Overview
Updates apps/server development startup to run via tsx instead of bun, improving Windows compatibility for local dev.

Adds tsx as a dev dependency (and updates the lockfile) and introduces scripts/package-scripts.test.ts to assert the server dev script remains tsx src/bin.ts going forward.

Reviewed by Cursor Bugbot for commit 675b82f. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0a3c1b55-4c38-4912-82c4-fc973f3f45a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Apr 10, 2026
macroscopeapp[bot]
macroscopeapp bot previously approved these changes Apr 10, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 10, 2026

Approvability

Verdict: Approved

This is a straightforward dev environment fix that changes the TypeScript runner from bun to tsx for Windows compatibility. Changes are limited to a dev script, adding a dependency, and a regression test. No production runtime behavior is affected.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
Copy link
Copy Markdown
Member

we don't use node 22 so the running ts files doens't apply

@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Apr 10, 2026
@RonWelWork
Copy link
Copy Markdown
Author

RonWelWork commented Apr 10, 2026

Good catch. I checked this against supported Node 24, and you're right that the root node ...ts part is not a strong argument here: scripts/dev-runner.ts does run under Node 24, so I removed those root/package-level changes from the PR.

I narrowed the patch to the Windows apps/server dev path only:

  • keep root scripts unchanged
  • keep apps/server build unchanged
  • switch only apps/server dev from bun run src/bin.ts to tsx src/bin.ts
  • keep a focused regression test for that server dev runtime expectation

The remaining issue I was targeting is that the current Windows server dev path goes through Bun, and that fails before normal app use because Bun PTY support is unavailable there.

@macroscopeapp macroscopeapp bot dismissed their stale review April 10, 2026 22:05

Dismissing prior approval to re-evaluate cb3251d

Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3d802cb. Configure here.

@RonWelWork
Copy link
Copy Markdown
Author

Addressed both Cursor Bugbot notes in the latest push:

  • restored configVersion: 1 in bun.lock so the PR no longer changes Bun linker behavior
  • strengthened the regression test to assert the exact expected dev command (tsx src/bin.ts) instead of only rejecting the old Bun command

Re-ran:

  • vitest run scripts/package-scripts.test.ts
  • fmt
  • lint
  • typecheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants