ddl, model: fix unexpected missing analyze for multi schema change (#64337)

[ti-chi-bot]

This is an automated cherry-pick of #64337

What problem does this PR solve?

Issue Number: ref #63366

Problem Summary:

If the last sub job in the multi schema change doesn't need reorg (i.e., no index involved), the analyze task will be skipped.

Take the following SQL as example, since c2 has no index on it, the state is directly converted to AnalyzeStateSkipped, even if modifying c1 requires reorg.

create table t2(id int, c1 int, c2 int, index i1(c1));
alter table t2 modify column c1 char(16), modify column c2 char(16);

c1: ReorgStageModifyColumnCompleted -> AnalyzeStateSkipped
(NeedAnalyze == false)
c2: ReorgStageModifyColumnCompleted -> AnalyzeStateSkipped
(NeedAnalyze == true & len(changingIdx) == 0)

What changed and how does it work?

The problems is caused by inaccurate value for SubJob.NeedAnalyze. That is, the last job with NeedAnalyze == true is not the last job that does reorg. To fix this:

• Remove NeedAnalyze since it's not accurate.
• For sub jobs, they are converted into non-revertible state after reorg is finished.
• For multi schema change, the analyze is done in the parent job after all sub jobs are non-revertible.

This PR also do the following things

1. move a bunch of function, variables related to modify column from ddl to model package.
2. Replace CtxVars with boolean value, as it's used by MODIFY COLUMN and store a single bool.
3. filter out temporary columns from the display information of analyze. Previously, we may get output like: auto analyze table all indexes, columns a, b, c,_Col$_c_0 with 256 buckets, 100 topn, 1 samplerate

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

@joechenrh This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

[ti-chi-bot]

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

1. It must be approved by the approvers firstly.
2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benjamin2037 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS
• pkg/ddl/OWNERS
• pkg/meta/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[joechenrh]

/retest

[ti-chi-bot]

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-br-integration-test	0e84a34	link	true	/test pull-br-integration-test
idc-jenkins-ci-tidb/build	0e84a34	link	true	/test build
idc-jenkins-ci-tidb/check_dev_2	0e84a34	link	true	/test check-dev2
idc-jenkins-ci-tidb/check_dev	0e84a34	link	true	/test check-dev
idc-jenkins-ci-tidb/unit-test	0e84a34	link	true	/test unit-test
idc-jenkins-ci-tidb/mysql-test	0e84a34	link	true	/test mysql-test
pull-unit-test-ddlv1	0e84a34	link	true	/test pull-unit-test-ddlv1

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.