Conversation
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
Welcome @docsir! |
lichunzhu
left a comment
There was a problem hiding this comment.
We shouldn't use string to save and sort all the values.
For integer values we may get "115 < 12" if we sort in this way.
fix #334
For dump.go,I have added a func for sort pkVals.
This change will make sure us to see dumpling dump data correctly.