i18n: add Related resources to more docs#22898
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request adds a "Related Resources" section to multiple documentation files, utilizing the <ResourceCard> component to link to relevant labs, blogs, and videos. The feedback identifies a grammatical inconsistency in a lab title within the tidb-resource-control-ru-groups.md file, suggesting a correction to ensure consistency with other titles added in this PR.
| ## 関連リソース {#related-resources} | ||
|
|
||
| <RelatedResources> | ||
| <ResourceCard title="管理 TiDB 演習 5: リソース制御を使用して混合ワークロードを管理" type="lab" link="https://labs.tidb.io/ja/labs/demo_006" imgSrc="https://lab-static.pingcap.com/quick-demo/dba_303_ch05_en.png" duration="90 分" /> |
There was a problem hiding this comment.
The title of the lab is grammatically incomplete. Since it uses the conjunctive form を使用して (using), it should be followed by a verb in its dictionary form (管理する) to be consistent with other lab titles in this PR (e.g., インポートする, 使用する, 複製する).
| <ResourceCard title="管理 TiDB 演習 5: リソース制御を使用して混合ワークロードを管理" type="lab" link="https://labs.tidb.io/ja/labs/demo_006" imgSrc="https://lab-static.pingcap.com/quick-demo/dba_303_ch05_en.png" duration="90 分" /> | |
| <ResourceCard title="管理 TiDB 演習 5: リソース制御を使用して混合ワークロードを管理する" type="lab" link="https://labs.tidb.io/ja/labs/demo_006" imgSrc="https://lab-static.pingcap.com/quick-demo/dba_303_ch05_en.png" duration="90 分" /> |
References
- Documentation should prioritize clarity, completeness, and readability, ensuring that sentence structures are logical and consistent. (link)
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?