Skip to content

i18n: add Related resources to more docs#22898

Open
Oreoxmt wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
Oreoxmt:ja-add-related-resources
Open

i18n: add Related resources to more docs#22898
Oreoxmt wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
Oreoxmt:ja-add-related-resources

Conversation

@Oreoxmt
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt commented May 15, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt self-assigned this May 15, 2026
@Oreoxmt Oreoxmt added the translation/no-need No need to translate this PR. label May 15, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oreoxmt. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 15, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a "Related Resources" section to multiple documentation files, utilizing the <ResourceCard> component to link to relevant labs, blogs, and videos. The feedback identifies a grammatical inconsistency in a lab title within the tidb-resource-control-ru-groups.md file, suggesting a correction to ensure consistency with other titles added in this PR.

## 関連リソース {#related-resources}

<RelatedResources>
<ResourceCard title="管理 TiDB 演習 5: リソース制御を使用して混合ワークロードを管理" type="lab" link="https://labs.tidb.io/ja/labs/demo_006" imgSrc="https://lab-static.pingcap.com/quick-demo/dba_303_ch05_en.png" duration="90 分" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The title of the lab is grammatically incomplete. Since it uses the conjunctive form を使用して (using), it should be followed by a verb in its dictionary form (管理する) to be consistent with other lab titles in this PR (e.g., インポートする, 使用する, 複製する).

Suggested change
<ResourceCard title="管理 TiDB 演習 5: リソース制御を使用して混合ワークロードを管理" type="lab" link="https://labs.tidb.io/ja/labs/demo_006" imgSrc="https://lab-static.pingcap.com/quick-demo/dba_303_ch05_en.png" duration="90 分" />
<ResourceCard title="管理 TiDB 演習 5: リソース制御を使用して混合ワークロードを管理する" type="lab" link="https://labs.tidb.io/ja/labs/demo_006" imgSrc="https://lab-static.pingcap.com/quick-demo/dba_303_ch05_en.png" duration="90 分" />
References
  1. Documentation should prioritize clarity, completeness, and readability, ensuring that sentence structures are logical and consistent. (link)

github-actions Bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant