-
Notifications
You must be signed in to change notification settings - Fork 709
Add integration with Microsoft Fabric #22373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @lilin90, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new documentation outlining the integration of TiDB with Microsoft Fabric. It details how TiCDC facilitates the replication of incremental data from TiDB to Microsoft Fabric's mirrored databases, leveraging open mirroring for direct data transfer. This integration aims to provide continuous, near real-time data availability in Microsoft Fabric OneLake, supporting advanced AI and analytics workloads. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new section to the data integration overview page about integrating TiDB with Microsoft Fabric. The new content provides a good overview of the integration. I have suggested a few minor wording improvements for better clarity, technical accuracy, and consistency with the documentation style guide. Overall, this is a valuable addition to the documentation.
integration-overview.md
Outdated
| You can use TiCDC to replicate incremental data from TiDB to Microsoft Fabric. With [open mirroring](https://learn.microsoft.com/en-us/fabric/mirroring/open-mirroring), TiDB can write change data directly to a mirrored database in Fabric. This enables continuous, near real-time data replication from any TiDB deployment environment to Microsoft Fabric OneLake, making the data readily available for AI and analytics workloads. | ||
|
|
||
| For details, see this blog post [How to Replicate TiDB to a Mirrored Database in Microsoft Fabric with TiCDC](https://www.pingcap.com/blog/replicate-tidb-mirrored-database-microsoft-fabric-ticdc/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve clarity, technical accuracy, and conciseness, I suggest a few revisions to this new section:
- In the first paragraph, attribute the action of writing data to
TiCDCinstead ofTiDBfor technical accuracy. - Shorten
any TiDB deployment environmenttoany TiDB deployment. - Use
your datato align with the second-person writing style. - In the link, remove "this blog post" to be more direct and consistent with other sections.
These changes align with the repository's documentation style guide.
| You can use TiCDC to replicate incremental data from TiDB to Microsoft Fabric. With [open mirroring](https://learn.microsoft.com/en-us/fabric/mirroring/open-mirroring), TiDB can write change data directly to a mirrored database in Fabric. This enables continuous, near real-time data replication from any TiDB deployment environment to Microsoft Fabric OneLake, making the data readily available for AI and analytics workloads. | |
| For details, see this blog post [How to Replicate TiDB to a Mirrored Database in Microsoft Fabric with TiCDC](https://www.pingcap.com/blog/replicate-tidb-mirrored-database-microsoft-fabric-ticdc/). | |
| You can use TiCDC to replicate incremental data from TiDB to Microsoft Fabric. With [open mirroring](https://learn.microsoft.com/en-us/fabric/mirroring/open-mirroring), TiCDC writes change data directly to a mirrored database in Fabric. This process provides continuous, near real-time data replication from any TiDB deployment to Microsoft Fabric OneLake, making your data readily available for AI and analytics workloads. | |
| For details, see [How to Replicate TiDB to a Mirrored Database in Microsoft Fabric with TiCDC](https://www.pingcap.com/blog/replicate-tidb-mirrored-database-microsoft-fabric-ticdc/). |
References
- The style guide emphasizes clarity and simplicity (line 14), technical accuracy (line 16), using the second person ("you") (line 22), and avoiding unnecessary words (line 24). The suggested changes improve the text based on these principles. (link)
What is changed, added or deleted? (Required)
Added integration with Microsoft Fabric
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?