Conversation
- Extract collectServicesByType() helper method in ConfigurationDefinitionPass to eliminate 8 duplicated foreach loops - Add validateSchemaAwareSettings() helper method in ConfigurationValidationService to reduce duplication across validation methods - Fix line length issue in ConfigurationDefinitionPass (split long line) - Reduces cognitive complexity and improves maintainability
Add @phpstan-ignore-next-line comments for children() method calls that fail type inference with Symfony 6.4.0 (lowest dependencies). The children() method returns NodeParentInterface in older versions instead of NodeBuilder, causing PHPStan to complain about undefined methods like scalarNode(), enumNode(), etc.
Move @phpstan-ignore-next-line comments to the correct lines where the actual failing method calls occur (scalarNode, variableNode, arrayNode, enumNode) instead of on the children() line. PHPStan complains about these method calls, not about children() itself.
# Conflicts: # src/DataSource/Loader/HttpLoader.php
|
# Conflicts: # composer.json # src/Resources/config/pimcore/routing.yml
unified tool naming updated docs added create and save data importer config tool
|
|
@copilot can you analyse this PR and check if there are any BC breaks in it? |
Here is the full BC break analysis for this PR: Overall conclusion: No BC breaks for existing custom implementations. What was checked
One point to watchA new required runtime dependency was added to
These are new entries in |
This pull request introduces significant improvements to the extensibility, validation, and AI integration capabilities of the Data Importer bundle. The changes include enhanced documentation for custom strategy development, new developer tools for configuration validation and schema introspection, experimental support for AI agent integration via MCP, and updates to example configurations. Additionally, interfaces for schema awareness and validation are now implemented in core cleanup strategies, and minor dependency and code quality improvements are made.
Extensibility and Developer Tools
SchemaAwareInterface,DataTargetFieldValidatorInterface, andTransformationTypeAwareInterfaceto enable automatic validation, schema introspection, and AI agent support.README.mdto include links to new extension documentation.Validation and Schema Awareness
SchemaAwareInterfacein core cleanup strategies (DeleteStrategy,UnpublishStrategy) to provide schema descriptions and enable validation tooling. [1] [2] [3]Example Configurations
Dependency and Codebase Improvements
composer.jsonto add dependencies for MCP SDK and HTTP message bridge, and to restrict plugin discovery forphp-http/discovery. [1] [2]phpstan-bootstrap.php. [1] [2]