Skip to content

Comments

docs: condense AI instruction files#3571

Merged
PierreBrisorgueil merged 2 commits intomasterfrom
chore/condense-ai-instruction-files
Feb 24, 2026
Merged

docs: condense AI instruction files#3571
PierreBrisorgueil merged 2 commits intomasterfrom
chore/condense-ai-instruction-files

Conversation

@PierreBrisorgueil
Copy link
Collaborator

@PierreBrisorgueil PierreBrisorgueil commented Feb 24, 2026

Summary

  • CLAUDE.md: replaced canonical commands table (~17 rows) with one-liner reference to package.json scripts; replaced stack merge workflow block with one-liner reference to README.
  • .github/copilot-instructions.md: replaced canonical commands list (~11 lines) with one-liner reference to package.json scripts.
  • AGENTS.md: removed Preflight section (already delegated via CLAUDE.md header) and Review output convention section.
  • .claude/agents/stack-maintainer.md: removed Example review section at the bottom.
  • README.md: replaced Claude Code skills table with a one-liner; removed Modularity Rules subsection that duplicated architecture described elsewhere in the file.

Total: 5 files changed, ~65 lines removed, duplication eliminated.

Test plan

  • Verify no source code files were modified (docs/instruction files only)
  • Confirm all links and references in remaining content are still valid
  • Confirm CLAUDE.md, copilot-instructions.md, and AGENTS.md each still contain all essential non-duplicated content

Summary by CodeRabbit

  • Documentation
    • Consolidated canonical command references to centralized script pointers.
    • Replaced detailed skills tables and modularity rules with concise pointers to skill documentation.
    • Removed several outdated guidance sections and example review content to reduce redundancy.
    • Added a caution note advising manual conflict resolution during stack merges.

Copilot AI review requested due to automatic review settings February 24, 2026 08:46
@coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13aadc1 and c85a8ba.

📒 Files selected for processing (1)
  • README.md

📝 Walkthrough

Walkthrough

Removed example and editorial sections and consolidated command references across docs: .claude/agents/stack-maintainer.md, .github/copilot-instructions.md, AGENTS.md, CLAUDE.md, and README.md now point to centralized script/skill locations instead of repeating detailed command blocks or review examples.

Changes

Cohort / File(s) Summary
Documentation cleanup
\.claude/agents/stack-maintainer.md, AGENTS.md
Removed the "Example review" section and the Preflight / Review output convention sections (editorial deletions only).
Command reference simplification
\.github/copilot-instructions.md, CLAUDE.md
Replaced detailed canonical/command blocks with single-line references to package.json scripts or README stack merge instructions; formatting tweaks to prompts table in copilot file.
README consolidation
README.md
Removed detailed skills table and Modularity Rules; replaced with a concise line directing readers to .claude/skills/. Added a manual conflict-resolution caution note under Stack Merge Workflow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Possibly related PRs

Suggested labels

chore

Poem

🐰 I nibbled through docs with a hop and a grin,
Trimmed examples and links to tidy within.
Now commands point true where the scripts softly dwell —
A neat little burrow where knowledge sits well. 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers the summary, scope, and test plan but lacks explicit sections for validation checklist, guardrails verification, and risk assessment as defined in the template. Add explicit Validation and Guardrails check sections with checkboxes, clarify risk level (appears low), and confirm all essential non-duplicated content remains for user confidence.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'docs: condense AI instruction files' clearly summarizes the main change—consolidating documentation by removing duplication and replacing lengthy sections with concise references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/condense-ai-instruction-files

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.93%. Comparing base (437fdee) to head (c85a8ba).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3571   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files          20       20           
  Lines         516      516           
  Branches      140      140           
=======================================
  Hits          495      495           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
CLAUDE.md (2)

59-59: Make the stack-merge pointer more precise.

“Stack merge workflow section” is a bit vague; consider naming the exact heading so readers can find it quickly and keep it merge-friendly.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CLAUDE.md` at line 59, Change the vague phrase "stack merge workflow section"
to a precise heading reference in the sentence — replace it with the exact
README heading name (e.g., "Stack merge workflow") or include the full heading
text in quotes so readers can jump directly to that section; update the line to
read something like "Stack merge: see README — 'Stack merge workflow' section."

15-15: Add a stable anchor to the scripts reference.

The one-liner is fine, but consider adding the exact README/package.json section name (or a heading anchor) to reduce ambiguity if scripts or docs grow.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@CLAUDE.md` at line 15, The one-line reference "Scripts: see `package.json` →
`scripts` section." is ambiguous; update the CLAUDE.md line to point to a stable
anchor by referencing the exact heading or key path (e.g., the README heading
"Scripts" or the explicit `package.json` key "scripts") so readers can jump
directly to the section—replace the sentence with a precise anchor-style
reference such as "Scripts: see README 'Scripts' section (or package.json
`scripts` key)" or add the README/package.json heading anchor you use to make
the link stable.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@CLAUDE.md`:
- Line 59: Change the vague phrase "stack merge workflow section" to a precise
heading reference in the sentence — replace it with the exact README heading
name (e.g., "Stack merge workflow") or include the full heading text in quotes
so readers can jump directly to that section; update the line to read something
like "Stack merge: see README — 'Stack merge workflow' section."
- Line 15: The one-line reference "Scripts: see `package.json` → `scripts`
section." is ambiguous; update the CLAUDE.md line to point to a stable anchor by
referencing the exact heading or key path (e.g., the README heading "Scripts" or
the explicit `package.json` key "scripts") so readers can jump directly to the
section—replace the sentence with a precise anchor-style reference such as
"Scripts: see README 'Scripts' section (or package.json `scripts` key)" or add
the README/package.json heading anchor you use to make the link stable.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a671a71 and 13aadc1.

📒 Files selected for processing (5)
  • .claude/agents/stack-maintainer.md
  • .github/copilot-instructions.md
  • AGENTS.md
  • CLAUDE.md
  • README.md
💤 Files with no reviewable changes (2)
  • .claude/agents/stack-maintainer.md
  • AGENTS.md

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces duplication across the repository’s AI/instruction documentation by replacing repeated command/workflow blocks with references to the canonical sources (package.json scripts, README sections, and .claude/skills/).

Changes:

  • Condensed canonical command listings to a single reference to package.json scripts.
  • Replaced detailed skill/modularity sections with brief pointers to the authoritative locations.
  • Removed example/redundant sections from agent/instruction documents to keep guidance DRY.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
README.md Condenses Claude skills/modularity guidance into a one-line pointer to .claude/skills/.
CLAUDE.md Replaces command table with a package.json reference; replaces stack merge commands with a pointer to README.
AGENTS.md Removes duplicated preflight/review-format guidance, deferring to CLAUDE.md.
.github/copilot-instructions.md Replaces canonical command list with a package.json reference; keeps prompts table.
.claude/agents/stack-maintainer.md Removes the example review block to reduce duplication.

Caution was lost when CLAUDE.md stack merge workflow was replaced by a
pointer to README. Adding it back directly in README as the source of truth.

Closes review feedback on #3571
@PierreBrisorgueil PierreBrisorgueil merged commit 4ca1822 into master Feb 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant