Skip to content

Conversation

@jbarata
Copy link

@jbarata jbarata commented Feb 7, 2013

without a proper namespace, the keydown event was being unbinded of every elemnt in the page and those stopped working. For example, it was unbinding existing shortcuts in the page where we are using js-shortcuts lib

without a proper namespace, the keydown event was being unbinded of every elemnt in the page and those stopped working. For example, it was unbinding existing shortcuts in the page (using Shortcuts.Js lib)
@pickhardt
Copy link
Owner

Thanks! I'll include this in the next version.

Jeff Pickhardt
pickhardt@gmail.com

On Thu, Feb 7, 2013 at 7:28 AM, Joao Barata notifications@github.comwrote:

without a proper namespace, the keydown event was being unbinded of every
elemnt in the page and those stopped working. For example, it was unbinding

existing shortcuts in the page where we are using js-shortcuts lib

You can merge this Pull Request by running

git pull https://github.com/cob/Guiders-JS fix_keydown_binding_namespace

Or view, comment on, or merge it at:

#90
Commit Summary

  • fixed keydown event namespace

File Changes

Patch Links:

@jbarata
Copy link
Author

jbarata commented Feb 8, 2013

You're welcome!

PS. and thank you for sharing this very nice component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants