-
Notifications
You must be signed in to change notification settings - Fork 56
Three properties around fundamental groups #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
We should definitely be careful when adding properties, much more when adding three of them. |
|
Hmm, I think this requires serious discussion (which would maybe have been more appropriate in an "issue"). Discussion about possible alternative terminologies, related theorems, etc, etc. Adding all these different properties at the same time also seems not appropriate. Can we do it one property at a time instead? Starting with one, with some basic accompanying theorems and in other PRs some distinguishing example spaces as necessary. @felixpernegger FYI, in the past we used to have a bunch of property definitions that someone had added over the years. they did not have connections with any other properties. We decided to delete them all, and then only accept new properties if someone took the work to provide related theorems and related sample spaces. That's really the preferred way to go. |
|
If you want to put this as draft and discuss this in an issue, that would be fine too. Added later: Just saw that @Moniker1998 already marked this as draft. |
Well I can write more on this tomorrow, but the point really is that especiall semilocally simply connected is a basic property in algebraic topology we need to calculate fundamental groups (typically taught in a first course). It is quite odd for a topological database not to contain this in my opinion.There are a few connections as well (i.e. with locally path connected and simply connected) |
|
A classical counterexample (but embeddable in R^2) for non semilocally simply connected is the Haiwaiian earrings for example |
I don't think its odd since this database focuses on properties important to general topology, more so than algebraic topology. |
|
I think it's perfectly fine to add these properties, just that it needs to be discussed and done one at a time, in a series of PR adding theorems and examples for each, before moving on to the next. That would be the preferred approach. As to why it's not in pi-base yet, it's because of what @Moniker1998 said. Pi-base started as an online version of the book Counterexamples in topology, which was focused on general topology and did not contain anything related to algebraic topology. Other properties were added later, again mainly for general topology, because that's what the people involved in pi-base were interested in. It's a historical reason. |
See #818.
For my final PR of the year, I want to add the most important properties which are not in pi-base. Typically (?) semilocally simply connected and universal covers are covered in a first course in topology.
I add :
So far I only added the definitions and no theorems, I want to make sure my definitions are alright (can add theorems in later commit).
And while adding 3 properties at once is admittedly a bit much, they are all very closely related, so I think this is appropriate.