Conversation
I'm not sure if a corresponding change should be made to modalities.yaml, I'm having trouble finding where the latter table is used by the compiler macros.
Incorporate physio BEP section 4 to physiological-recordings.md
Add physio as a datatype
Some checks on formatting (particularly for how I entered the allowable values) might be necessary here, I also added some comments on the BEP document to flag potential issues or changes we could make going forward.
Removed example file structure for physiological recordings.
Add MeasureType descriptions section to documentation
Removed unnecessary code blocks and clarified recommendations for recording physiological data.
Added descriptions for various MeasureTypes related to physiological recordings.
Updates to src/modality-specific-files/physiological-recordings.md
Some checks on formatting (particularly for how I entered the allowable values) might be necessary here, I also added some comments on the BEP document to flag potential issues or changes we could make going forward.
Fix some rebasing issues
Member
Author
|
Notes on rebasing post eye-traking BEP merge:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to view the changes to the bids specification and for external contributors to engage with our changes.
It is a working copy of this PR.
bep045 is the the target branch of every other PR in this repository (i.e. it acts as a canary branch).