Revert result inference for scalar method#588
Conversation
99c9c87 to
be153c1
Compare
|
Please explain in your own words why this has to be reverted. |
|
I believe it is summarized here: #520 (comment) |
|
I'm on a phone and I can't load the comment. I'd like a brief explanation and also some tests that fail when this is not reverted. |
When we're computing the template values of For instance,
I didn't revert HYDRATE_ARRAY, dunno if @janedbal has a counter example for this case. I would say that this dev is working something like 90% of the time but such false-positive is non acceptable so we should keep mixed until it's fixed. For non-regression test, we need to directly test hydration mode on different driver so I made #587 but I think @janedbal had something else in mind. |
|
Please add a test case that would fail if the changes weren't reverted. |
|
Thank you. |
As recommended here: #520 (comment)