Platform test: compare inferred types with real SQL engine results#572
Merged
ondrejmirtes merged 8 commits intophpstan:1.4.xfrom May 31, 2024
Merged
Conversation
617b7e2 to
2a597cb
Compare
2a597cb to
486992b
Compare
2d1adbf to
5dfa0ca
Compare
ondrejmirtes
requested changes
May 31, 2024
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
This is really nice :)
Two questions:
- Why not cover PHP 7.2+?
- Why not cover PHP 8.2+?
Contributor
Author
The main point of platform test is to cover different PHP behaviours and that changed only in PHP 8.1. Take this as a starting point, I have a big list of needed improvements of this test. Using complete range of PHP versions can be added. |
ondrejmirtes
approved these changes
May 31, 2024
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.