Reduce memory consumption in FilesCollection#1219
Open
ckuran wants to merge 1 commit into
Open
Conversation
b506c1d to
686c3cd
Compare
veewee
reviewed
May 22, 2026
| foreach ($files as $file) { | ||
| $this->add(new SymfonySplFileInfo($file, dirname($file), $file)); | ||
| foreach ($data as $path) { | ||
| $this->add($path); |
Contributor
There was a problem hiding this comment.
The signature however is ArrayCollection<array-key, \SplFileInfo>.
Now it also contains strings making it result in broken public API contracts (see e.g; the getFirst() vs first() and optionally similar methods like last, current, ...)
I'm also wondering: now every time an iterator goes over it, it will be hydrated.
So if you have more tasks (or file filters), it will always increase memory.
This makes me wonder: what is the ACTUAL memory issue that we are trying to solve?
Can we find a better solution than keeping it as strings intermediate?
It also has been a while but: what benifit does SymfonySplFileInfo give over regular SplFileInfo here. Which one does add the overhead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces memory consumption in
FilesCollection. The key changes:amphp/parallel, the file collection is serialized and shipped to worker processes. Previously each file was immediately unpacked into a fullSymfonySplFileInfoobject levereging a lot of memory. Now the worker receives plain strings and only builds the objects when something actually iterates over themPeak memory usage: X.X MBat the end of commands for easier diagnostic (only in verbose mode)Results
Before
After