Merged
Conversation
…to the debug console
…w-v5--refactor # Conflicts: # src/Dispatch/Dispatcher.php # src/Dispatch/HeaderApplier.php # src/Dispatch/HtmlDocumentProcessor.php # src/Dispatch/TrailingSlashRedirector.php
* feature: custom error script * wip: test * tweak: type safe config mocking * wip: test file * tweak: output buffer --------- Co-authored-by: Greg Bowler <greg@g105b.com>
…w-v5--refactor # Conflicts: # test/phpunit/ApplicationTest.php
Member
Author
|
I'm finishing this up today. High value tasks:
Once these tests are written, |
…ctor # Conflicts: # src/Middleware/RequestHandler.php
Member
Author
|
After checking the phpunit coverage output, the priority is as follows:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v5 introduces some new techniques for making the request/response simpler, and this PR brings everything together in a refactor to improve readability and reduce overall complexity of classes, etc.