fix: set language on CodeNode for markdown fenced code blocks#1302
Open
jonathanhefner wants to merge 1 commit intophpDocumentor:mainfrom
Open
fix: set language on CodeNode for markdown fenced code blocks#1302jonathanhefner wants to merge 1 commit intophpDocumentor:mainfrom
CodeNode for markdown fenced code blocks#1302jonathanhefner wants to merge 1 commit intophpDocumentor:mainfrom
Conversation
`CodeBlockParser::parse()` stored the fenced code info string in
`options['caption']` via `withOptions()`, but nothing ever read that
value — `CodeNode::getCaption()` returns the typed `$caption` property,
not `getOption('caption')`. As a result, `CodeNode::getLanguage()`
always returned `null` for markdown code blocks, producing
`class="language-"` in the rendered HTML and preventing syntax
highlighting.
Replace the dead `withOptions(['caption' => ...])` call with
`setLanguage()` using `getInfoWords()[0]` from the CommonMark
`FencedCode` node, matching both the RST parser's behavior
(`CodeBlockDirective`) and league/commonmark's own `FencedCodeRenderer`.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeBlockParser::parse()stored the fenced code info string inoptions['caption']viawithOptions(), but nothing ever read that value —CodeNode::getCaption()returns the typed$captionproperty, notgetOption('caption'). As a result,CodeNode::getLanguage()always returnednullfor markdown code blocks, producingclass="language-"in the rendered HTML and preventing syntax highlighting.Replace the dead
withOptions(['caption' => ...])call withsetLanguage()usinggetInfoWords()[0]from the CommonMarkFencedCodenode, matching both the RST parser's behavior (CodeBlockDirective) and league/commonmark's ownFencedCodeRenderer.