Skip to content

openssl: fix memory leaks when session callback returns wrong type #21966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndossche wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −2
Open

openssl: fix memory leaks when session callback returns wrong type #21966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ext/openssl/xp_ssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1634,13 +1634,12 @@ static SSL_SESSION *php_openssl_session_get_cb(SSL *ssl, const unsigned char *se
SSL_SESSION_up_ref(obj->session);
session = obj->session;
}
zval_ptr_dtor(&retval);
} else if (Z_TYPE(retval) != IS_NULL) {
zend_type_error("session_get_cb return type must be null or OpenSSLSession");
return NULL;
}
}

zval_ptr_dtor(&retval);
zval_ptr_dtor(&args[1]);

*copy = 0;
Expand Down
Loading