[DRAFT] [WIP] Initial zend_class_alias#18789
Draft
DanielEScherzer wants to merge 30 commits intophp:masterfrom
Draft
[DRAFT] [WIP] Initial zend_class_alias#18789DanielEScherzer wants to merge 30 commits intophp:masterfrom
DanielEScherzer wants to merge 30 commits intophp:masterfrom
Conversation
DanielEScherzer
force-pushed
the
alias
branch
from
eaa7d0d to
c178ca6
Compare
Member
Author
|
I can't seem to get ASAN to complain locally... |
Probably going to have a bunch of failures but I can't find any more locally
Need to actually add zend_class_alias->attributes but ran out of time for now
Not yet wired to emit anything yet though
Just switching to a zend_class_alias object should be easier
Member
Author
|
Still unable to reproduce ASAN failures locally, or get the JIT failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably going to have a bunch of failures but I can't find any more locally