Fix call to ssh2_auth_pubkey[_file]() without password #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch taken from https://bugs.php.net/patch-display.php?bug=79702&patch=ssh2_fix_nullpointer_deref.patch&revision=1617965812 by thomas at shadowweb dot org Resolves: https://bugs.php.net/bug.php?id=79702
Port of the previous fix for ssh2_auth_pubkey_file() to the passwordless function introduced after that patch. Related: https://bugs.php.net/bug.php?id=79702
Collaborator
|
Thank you |
Contributor
Author
|
Thanks for merging so quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ssh2 extension segfaults in certain circumstances when using
ssh2_auth_pubkeyandssh2_auth_pubkey_filewithout a password.This has been reported 2020-06-15 at https://bugs.php.net/bug.php?id=79702 and a patch was provided at 2021-04-09 by thomas at shadowweb dot org.
This PR contains two commits:
ssh2_auth_pubkey_filessh2_auth_pubkeythat was added after the original patch had been written.Resolves: https://bugs.php.net/bug.php?id=79702