-
Notifications
You must be signed in to change notification settings - Fork 429
docs: revise bug report template for improved instructions #2181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dunglas
wants to merge
1
commit into
main
Choose a base branch
from
dunglas-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−6
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -7,16 +7,18 @@ body: | |||||||
| attributes: | ||||||||
| value: | | ||||||||
| Thanks for taking the time to fill out this bug report! | ||||||||
| Before submitting a bug, please double-check that your problem [is not | ||||||||
| a known issue](https://frankenphp.dev/docs/known-issues/) | ||||||||
| (especially if you use XDebug or Tideways), and that is has not | ||||||||
| [already been reported](https://github.com/php/frankenphp/issues). | ||||||||
|
|
||||||||
| Before submitting, please ensure that your issue: | ||||||||
|
|
||||||||
| * Is not [a known issue](https://frankenphp.dev/docs/known-issues/). | ||||||||
| * Has not [already been reported](https://github.com/php/frankenphp/issues). | ||||||||
| * Is not caused by a dependency (like Caddy or PHP itself). If the issue is with a dependency, please report it to the upstream project directly. | ||||||||
| - type: textarea | ||||||||
| id: what-happened | ||||||||
| attributes: | ||||||||
| label: What happened? | ||||||||
| description: | | ||||||||
| Tell us what you do, what you get and what you expected. | ||||||||
| Tell us what you do, what you get, and what you expected. | ||||||||
| Provide us with some step-by-step instructions to reproduce the issue. | ||||||||
| validations: | ||||||||
| required: true | ||||||||
|
|
@@ -30,7 +32,7 @@ body: | |||||||
| - Docker (Debian Bookworm) | ||||||||
| - Docker (Alpine) | ||||||||
| - deb packages | ||||||||
| - rpm packages | ||||||||
| - RPM packages | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| - Static binary | ||||||||
| - Custom (tell us more in the description) | ||||||||
| default: 0 | ||||||||
|
|
@@ -55,6 +57,8 @@ body: | |||||||
| options: | ||||||||
| - GNU/Linux | ||||||||
| - macOS | ||||||||
| - Windows | ||||||||
| - FreeBSD | ||||||||
| - Other (tell us more in the description) | ||||||||
| default: 0 | ||||||||
| validations: | ||||||||
|
|
||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're renaming
rpmtoRPMwe should do the same here.Also add
apk(alpine)packages.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC,
debis lowercased. IDK for apk.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find all three referred to in both lowercase and uppercase. Not sure what is the "factually correct" capitalisation for
apk.