Fix GH-1132: Document mb_strlen invalid encoding behavior change in P…#5418
Open
GabrielCordeiroBarrosoTeles wants to merge 2 commits intophp:masterfrom
Conversation
jordikroon
reviewed
Mar 9, 2026
| <entry>8.0.0</entry> | ||
| <entry> | ||
| Passing an invalid encoding now throws a | ||
| <classname>ValueError</classname>. Previously, the return value was |
Contributor
There was a problem hiding this comment.
Please use <exceptionname>ValueError</exceptionname> instead.
And Previously, &false; was returned. makes more sense here since prior to 8.0, false was always returned on error.
https://github.com/php/php-src/blob/PHP-7.4.33/ext/mbstring/mbstring.c#L2503
There was a problem hiding this comment.
Done, @jordikroon . Switched to <exceptionname>ValueError</exceptionname> and updated to "Previously, &false; was returned." to match the PHP 7.4 source. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1132
Documents that passing an invalid encoding to
mb_strlen()had undefined behavior before PHP 8.0 (could returnfalse) and that as of PHP 8.0 aValueErroris thrown instead, as suggested in the issue discussion.