Skip to content

curl_multi_close: add changelog for NOP and deprecation#5179

Closed
DanielEScherzer wants to merge 1 commit intophp:masterfrom
DanielEScherzer:curlmulticlose-deprecation
Closed

curl_multi_close: add changelog for NOP and deprecation#5179
DanielEScherzer wants to merge 1 commit intophp:masterfrom
DanielEScherzer:curlmulticlose-deprecation

Conversation

@DanielEScherzer
Copy link
Copy Markdown
Member

No description provided.

@lacatoire
Copy link
Copy Markdown
Member

Thanks for adding the changelog entries! The 8.0.0 NOP entry looks good 👍 For the 8.5.0 deprecation though, I couldn't find evidence that curl_multi_close() was deprecated. Looking at
ext/curl/curl.stub.php, curl_close() has the deprecation attribute:

#[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")]                                                                                                                              
function curl_close(CurlHandle $handle): void {}                                                                                                                                                        
                                                                                                                                                                                                        
But https://github.com/php/php-src/blob/PHP-8.5/ext/curl/curl.stub.php#L109 doesn't seem to have one:                                                                                                   
                                                                                                                                                                                                        
function curl_multi_close(CurlMultiHandle $multi_handle): void {}                                                                                                                                       
                                                                                                                                                                                                        
Am I missing something? If it's intentionally not deprecated, maybe we should remove that entry from this PR.       

@DanielEScherzer
Copy link
Copy Markdown
Member Author

Good catch - this should have been for curl_share_close

@DanielEScherzer
Copy link
Copy Markdown
Member Author

Sent #5249 with the correct function

@DanielEScherzer DanielEScherzer deleted the curlmulticlose-deprecation branch February 4, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants