curl_multi_close: add changelog for NOP and deprecation#5179
Closed
DanielEScherzer wants to merge 1 commit intophp:masterfrom
Closed
curl_multi_close: add changelog for NOP and deprecation#5179DanielEScherzer wants to merge 1 commit intophp:masterfrom
DanielEScherzer wants to merge 1 commit intophp:masterfrom
Conversation
Member
|
Thanks for adding the changelog entries! The 8.0.0 NOP entry looks good 👍 For the 8.5.0 deprecation though, I couldn't find evidence that #[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")]
function curl_close(CurlHandle $handle): void {}
But https://github.com/php/php-src/blob/PHP-8.5/ext/curl/curl.stub.php#L109 doesn't seem to have one:
function curl_multi_close(CurlMultiHandle $multi_handle): void {}
Am I missing something? If it's intentionally not deprecated, maybe we should remove that entry from this PR. |
Member
Author
|
Good catch - this should have been for curl_share_close |
Member
Author
|
Sent #5249 with the correct function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.