eio/constants.xml: add dots at the ends of sentences…#3562
Merged
Conversation
Girgias
reviewed
Jul 26, 2024
Comment on lines
+100
to
+106
| <literal>'names'</literal> - array of directory names | ||
| <literal>'dents'</literal> - array of <literal>struct eio_dirent</literal>-like | ||
| arrays having the following keys each: | ||
| <literal>'name'</literal> - the directory name; | ||
| <literal>'type'</literal> - one of <emphasis>EIO_DT_*</emphasis> | ||
| constants; | ||
| <literal>'inode'</literal> - the inode number, if available, otherwise |
Member
There was a problem hiding this comment.
Or maybe just refer to eio_readdir() here; on that page there is the same information (which likely should be formatted in a more readable way; a (nested) list might be a good idea).
Member
|
Given that this PR has been open and the suggested change goes beyond the scope of this. I don't see a reason to keep block this much longer. If anyone wants to pick up the remaining comments, they are free to do so.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and formatting nits