Open
Conversation
Member
|
It's a good idea, but the |
Member
Author
|
@sy-records yeah that name was on the top of my head... Got ideas? |
Adds a new `reusable.yml` GitHub Actions workflow, that can be reused
by the `doc-base` repo and individual `php/doc-*` repos.
The new reusable workflow accepts inputs that control the repos it
checks out, the name of the language, and other tasks that the
`integration.yaml` file previously did.
The new `build.yml` file then uses the `reusable.yml` workflow by
passing parameters to run the same list of existing language builds.
The advantage of this is that `doc-base` acts as the baseline GitHub
Actions repo, and updates to it (such as changing the `runs-on` value,
updating `uses` values for other actions such as `actions/checkout`,
and other chores only need to be done on the `doc-base`, and not on
every `php/doc-*` repo.
Individual `php/doc-*` repos need to be updated to make use of the new
reusable workflows, e.g.:
```yml
name: "Build Ukrainian language documentation"
on:
push:
pull_request:
branches: "master"
workflow_dispatch:
jobs:
build:
uses: php/doc-base/.github/workflows/build-reusable.yml@master
with:
language: 'uk'
```
68d7858 to
f9df1ba
Compare
Member
Author
|
I changed the name from |
sy-records
approved these changes
Mar 5, 2025
| - "ja" | ||
| - "pl" | ||
| - "pt_br" | ||
| # - "ro" |
Member
There was a problem hiding this comment.
Suggested change
| # - "ro" | |
| # - "ro" |
LGTM.
Member
|
Please, try to incorporate the changes They are necessary to avoid CI running on previous versions of master, as GitHub CI caches the target of merge commit on PR creation, and confusingly, only updates the target when the PR is changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
reusable.ymlGitHub Actions workflow, that can be reused by thedoc-baserepo and individualphp/doc-*repos.The new reusable workflow accepts inputs that control the repos it checks out, the name of the language, and other tasks that the
integration.yamlfile previously did.The new
build.ymlfile then uses thereusable.ymlworkflow by passing parameters to run the same list of existing language builds.The advantage of this is that
doc-baseacts as the baseline GitHub Actions repo, and updates to it (such as changing theruns-onvalue, updatingusesvalues for other actions such asactions/checkout, and other chores only need to be done on thedoc-base, and not on everyphp/doc-*repo.Individual
php/doc-*repos need to be updated to make use of the new reusable workflows, e.g.: