Add Section 6.1 to the PER-CS 1.0 to 2.0 migration guide#139
Open
rodrigoprimo wants to merge 1 commit into
Open
Add Section 6.1 to the PER-CS 1.0 to 2.0 migration guide#139rodrigoprimo wants to merge 1 commit into
rodrigoprimo wants to merge 1 commit into
Conversation
PER-CS 2.0 added a new normative rule to Section 6.1 about the spacing between a type casting operator and the variable it is operating on. The rule is not currently documented in the migration guide. This commit adds the missing entry.
Crell
approved these changes
May 15, 2026
Collaborator
Crell
left a comment
Crell
left a comment
There was a problem hiding this comment.
This seems fine to me. Will leave open for a bit to see if anyone else from the WG disagrees.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PER-CS 2.0 introduces a new normative rule in Section 6.1:
The clause "and MUST be separated from the variable they are operating on by exactly one space" was added by #40 and is not present in Section 6.1 in 1.0. I'm new to this repository, so I might be missing something, but this change is not documented in the 2.0 migration guide, and I believe it should be.
This PR adds a Section 6.1 entry to
migration-2.0.md.The new Section 6.1 heading uses the same unversioned
php-fig.orgURL as the existing entries. This URL currently points to PER-CS 3.0. I'm not sure if this is correct. I opened #138 to discuss it.