Php cs fixer added and fixed SF6 deprecation notice #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symfony\Bridge\PhpUnit\SymfonyTestsListener added to output deprecations during tests
vgpastor
reviewed
Jan 28, 2023
vgpastor
left a comment
vgpastor
left a comment
There was a problem hiding this comment.
Why delete phpstan?
phpfixer and phpstan are compatibles and works fine together
| docker-compose run --rm -T php /usr/local/bin/php /app/vendor/bin/phpunit | ||
|
|
||
| phpstan: clear-cache | ||
| docker-compose run --rm -T php /usr/local/bin/php /app/vendor/bin/phpstan analyse |
There was a problem hiding this comment.
Why delete phpstan?
phpfixer and phpstan are compatibles and works fine together
Contributor
Author
There was a problem hiding this comment.
Very strange. I think it was a mistake.
gassan
force-pushed
the
php-cs-fixer-added
branch
2 times, most recently
from
b9521d5 to
96440b9
Compare
gassan
force-pushed
the
php-cs-fixer-added
branch
from
96440b9 to
9a2266a
Compare
gassan
changed the title
|
Can this be merged? the deprecation notice is really annoying on 8.2! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subj.
Plase adjuct .scrutinizer.yml config if necessary.