LiveViewTest: treat missing form id as error if form has phx-change#4128
Merged
LiveViewTest: treat missing form id as error if form has phx-change#4128
Conversation
This prevents users from accidentally disabling form recovery because they forgot to set an ID on a form. Closes #4124.
SteffenDE
force-pushed
the
sd-warn-form-missing-id
branch
from
8c56bcf to
12e3d50
Compare
josevalim
reviewed
Mar 17, 2026
josevalim
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents users from accidentally disabling form recovery because they forgot to set an ID on a form.
Closes #4124.
I also added a new way to have more granular control over reported test errors / warnings.