Minor Fixes Found By Dialyzer#74
Merged
josevalim merged 5 commits intophoenixframework:mainfrom Jan 27, 2025
Merged
Conversation
josevalim
reviewed
Jan 27, 2025
This reverts commit 7d5540d.
josevalim
reviewed
Jan 27, 2025
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves a couple of minor fixes that were found by dialyzer as I was messing with #73.
File.stream!call in code_sync.ex had its values out of order - the list of modes should be the last parameter of the call.FLAME.Pool.place_child/3, there was a match for an:ignorecase coming back fromFLAME.Runner.place_child/3. This case can't happen -FLAME.Runner.place_child/3calls out toFLAME.Runner.call/4, which will either exit, or return the value of the call toFLAME.Runner.remote_call/5, which can only return{:ok, {result, pids}}or{:exit, reason}.This PR was branched out from my fork which also includes the change from #73, which is why the commit for setting the timeout is also included here.