Skip to content

chore(deps, rust): update ms-vsliveshare.vsliveshare, rust-lang.rust-analyzer in devcontainer-metadata.json#1230

Merged
Ron (rjaegers) merged 1 commit intomainfrom
feature/amp-devcontainer-rust/update-vscode-extensions-devcontainer-metadata.json
Apr 5, 2026
Merged

chore(deps, rust): update ms-vsliveshare.vsliveshare, rust-lang.rust-analyzer in devcontainer-metadata.json#1230
Ron (rjaegers) merged 1 commit intomainfrom
feature/amp-devcontainer-rust/update-vscode-extensions-devcontainer-metadata.json

Conversation

@philips-software-forest-releaser
Copy link
Copy Markdown
Contributor

Note

Before merging this PR, please conduct a manual test checking basic functionality of the updated plug-ins. There are limited automated tests for the VS Code Extension updates.

Updates rust-lang.rust-analyzer from 0.3.2836 to 0.3.2845

Release notes

Commit: f1297b2
Release: 2026-03-30 (v0.3.2845)

Fixes

  • #21588 (first contribution) fix asm! sym operand parsing for parenthesized expr fragments.
  • #21871 revert TyLoweringContext::store after lowering parent defaults.
  • #21876 keep value when trying to produce a default call.
  • #21904 fix panic on trailing | in unmerge_match_arm.
  • #21838 skip usages inside macro expansions in destructure_{struct,tuple}_binding.
    • #21860, #21865 wrap ascribed type in Option<> or Result<> in desugar_try_expr with let - else.
  • #21744 keep comments in add_missing_match_arms.
  • #20681 fix indent after fixing trait_impl_redundant_assoc_item.
  • #21411 offer merge_match_arms on ambiguous identifier patterns.
  • #21709 fix spurious flychecks with multiple workspaces.

Internal Improvements

  • #21874 (first contribution) migrate generate_default_from_new assist to SyntaxEditor.
  • #21879 (first contribution) fix bounds check in debug_assert!.
  • #21823, #21859, #21900 implement signature type inference.
  • #21901, #21907 only allocate non-empty item blocks.
  • #21897 remove Arc from GenericParams and AstIdMap.
  • #21872 rename IndentLevel::single to zero.
  • #21856, #21867, #21866, #21870, #21884 replace make in replace_derive_with_manual_impl, generate_impl, generate_new, generate_trait_impl_text_intransitive and getter with SyntaxFactory.
  • #21853 extract default_fill_expr to utils.
  • #21862 don't trigger GC on slow tests, take 2.

See also the changelog post.

Updates ms-vsliveshare.vsliveshare from 1.0.5959 to 1.1.119

Release notes

@philips-software-forest-releaser philips-software-forest-releaser bot added dependencies Pull requests that update a dependency file vscode-extensions labels Apr 5, 2026
@philips-software-forest-releaser philips-software-forest-releaser bot requested a review from a team as a code owner April 5, 2026 03:39
@philips-software-forest-releaser philips-software-forest-releaser bot added dependencies Pull requests that update a dependency file vscode-extensions labels Apr 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 23 0 0 0.4s
✅ DOCKERFILE hadolint 3 0 0 0.38s
✅ JSON npm-package-json-lint yes no no 0.73s
✅ JSON prettier 21 4 0 0 0.8s
✅ JSON v8r 21 0 0 10.24s
✅ MARKDOWN markdownlint 12 0 0 0 1.34s
✅ MARKDOWN markdown-table-formatter 12 0 0 0 0.32s
✅ REPOSITORY checkov yes no no 26.11s
✅ REPOSITORY gitleaks yes no no 1.16s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 43.22s
✅ REPOSITORY secretlint yes no no 2.17s
✅ REPOSITORY syft yes no no 2.41s
✅ REPOSITORY trivy yes no no 12.27s
✅ REPOSITORY trivy-sbom yes no no 0.47s
✅ REPOSITORY trufflehog yes no no 5.92s
⚠️ SPELL lychee 83 1 0 21.53s
✅ YAML prettier 31 0 0 0 1.35s
✅ YAML v8r 31 0 0 13.16s
✅ YAML yamllint 31 0 0 1.26s

Detailed Issues

⚠️ SPELL / lychee - 1 error
[IGNORED] docker://pandoc/extra:3.9.0.0-ubuntu@sha256:72afa9c8d3300e5f10c9c4330e101725687f2179bffd912fb859c6d2ae85de62 | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.9.0.0-ubuntu@sha256:72afa9c8d3300e5f10c9c4330e101725687f2179bffd912fb859c6d2ae85de62)
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
📝 Summary
---------------------
🔍 Total..........126
✅ Successful.....123
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1

Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden

See detailed reports in MegaLinter artifacts

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.4.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-base:edgeghcr.io/philips-software/amp-devcontainer-base:pr-1230

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 145.22 MB 145.22 MB +620 B (+0%) 🔼
linux/arm64 137.54 MB 137.54 MB 61 B (0%) 🔽

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-1230

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 455.71 MB 455.71 MB +634 B (+0%) 🔼
linux/arm64 408.89 MB 408.89 MB 302 B (0%) 🔽

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 5, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-1230

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 544.77 MB 544.77 MB +644 B (+0%) 🔼
linux/arm64 526.23 MB 526.23 MB 2.05 kB (0%) 🔽

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

Test Results

 12 files   - 1   12 suites   - 1   17m 25s ⏱️ - 1m 9s
 32 tests  - 1   32 ✅  - 1  0 💤 ±0  0 ❌ ±0 
136 runs   - 1  136 ✅  - 1  0 💤 ±0  0 ❌ ±0 

Results for commit 7246601. ± Comparison against base commit a531283.

@rjaegers Ron (rjaegers) added this pull request to the merge queue Apr 5, 2026
Merged via the queue into main with commit 5d1986c Apr 5, 2026
54 of 55 checks passed
@rjaegers Ron (rjaegers) deleted the feature/amp-devcontainer-rust/update-vscode-extensions-devcontainer-metadata.json branch April 5, 2026 19:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

Pull Request Report (#1230)

Static measures

Description Value
Number of added lines 2
Number of deleted lines 2
Number of changed files 1
Number of commits 1
Number of reviews 1
Number of comments (w/o review comments) 6
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 15.4 Hours
Time that was spend on the branch before the PR was created 2 Sec
Time that was spend on the branch before the PR was merged 15.4 Hours
Time to merge after last review 2.1 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 1 Hours
Total time spend in last status check run on PR 15.5 Hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file vscode-extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant