Remove useless Result#1022
Merged
Merged
Conversation
Our `ToBytes` trait returns a `Result` instead of just `Bytes`. This is a reasonable forward looking decision, except not a single impl anywhere in the code base ever returns an error. And it's a good thing they don't, because the vast majority of the code which calls this method doesn't handle the error. It just unwraps. If it weren't for the dozens of unwraps everywhere, I would actually be in favor of leaving the Result there if we thought we might conceivably return an error in the future. But since we're not handling the errors, better to just get rid of it entirely.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
ToBytestrait returns aResultinstead of justBytes. This is a reasonable forward looking decision, except not a single impl anywhere in the code base ever returns an error. And it's a good thing they don't, because the vast majority of the code which calls this method doesn't handle the error. It just unwraps.If it weren't for the dozens of unwraps everywhere, I would actually be in favor of leaving the Result there if we thought we might conceivably return an error in the future. But since we're not handling the errors, better to just get rid of it entirely.