feat(resharding): use binary protocol for replication#1016
Open
meskill wants to merge 1 commit into
Open
Conversation
meskill
force-pushed
the
feat/replication-binary
branch
from
36b0194 to
a025a14
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use binary protocol for replication slot if
resharding_copy_formatset to binary.Performance benefits are minimal, guess mostly because of the current sequential streaming handling in replication (send -> wait for reply for every event).
I managed to get some improvements on benchmarks only with toxiproxy in case of limited bandwidth
otherwise no difference