Skip to content

Comments

Fix 3070 remove unused code of random spanning tree#3071

Merged
cvvergara merged 2 commits intopgRouting:developfrom
cvvergara:fix-3070-remove-unused-code-of-randomSpanningTree
Feb 19, 2026
Merged

Fix 3070 remove unused code of random spanning tree#3071
cvvergara merged 2 commits intopgRouting:developfrom
cvvergara:fix-3070-remove-unused-code-of-randomSpanningTree

Conversation

@cvvergara
Copy link
Member

@cvvergara cvvergara commented Feb 19, 2026

Fixes #3070 .

Changes proposed in this pull request:

  • Removes unused code and documentation of randomSpanningTree

@pgRouting/admins

Summary by CodeRabbit

  • Removals
    • The random spanning tree function and all associated infrastructure have been completely removed from the system. This includes the SQL function interface, comprehensive user documentation, example queries, test cases, and the underlying implementation code. If you previously relied on this capability, please explore alternative solutions for your spanning tree analysis and computation requirements.

@cvvergara cvvergara added this to the Release 4.1.0 milestone Feb 19, 2026
@cvvergara cvvergara requested a review from robe2 February 19, 2026 18:28
@cvvergara cvvergara added randomSpanningTree Remove rm of deprecated function or internal function labels Feb 19, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

This PR removes the entire pgr_randomSpanTree random spanning tree feature from pgRouting, including documentation, SQL functions, C++ headers, and implementation code. The feature was previously merged but never included in production releases.

Changes

Cohort / File(s) Summary
Documentation
doc/spanningTree/CMakeLists.txt, doc/spanningTree/pgr_randomSpanTree.rst, docqueries/spanningTree/randomSpanTree.*
Removed all documentation files and example queries for pgr_randomSpanTree feature.
Public API Headers
include/drivers/spanningTree/randomSpanningTree_driver.h, include/spanningTree/pgr_randomSpanningTree.hpp
Deleted public function declarations and C++ template class that provided the random spanning tree algorithm interface.
SQL Functions
sql/spanningTree/CMakeLists.txt, sql/spanningTree/randomSpanTree.sql, sql/spanningTree/_randomSpanTree.sql
Removed SQL wrapper functions (pgr_randomSpanTree and _pgr_randomSpanTree) and their build configuration references.
Implementation
src/spanningTree/CMakeLists.txt, src/spanningTree/randomSpanningTree.c, src/spanningTree/randomSpanningTree_driver.cpp
Deleted C PostgreSQL extension function and C++ driver implementation with graph construction and result handling logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

Code Cleanup

Suggested reviewers

  • robe2

Poem

🐰 Hops away the random trees,
No more infinite loops to chase,
With Boost's algorithm's pleas,
We clean the code and keep our pace!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing unused random spanning tree code and documentation as specified in issue #3070.
Linked Issues check ✅ Passed The pull request successfully removes all unused random spanning tree code and documentation mentioned in issue #3070, including SQL functions, C/C++ implementations, drivers, and related documentation files.
Out of Scope Changes check ✅ Passed All changes are in-scope deletions directly related to removing unused random spanning tree code and documentation as required by issue #3070; no extraneous modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cvvergara cvvergara merged commit f6ca7f3 into pgRouting:develop Feb 19, 2026
64 checks passed
@cvvergara cvvergara deleted the fix-3070-remove-unused-code-of-randomSpanningTree branch February 19, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

randomSpanningTree Remove rm of deprecated function or internal function

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup unused code for random spanning tree

2 participants