[ENHANCEMENT] cue/common: provide new standard definitions for datasource plugins
#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…source plugins Signed-off-by: AntoineThebaud <antoine.thebaud@yahoo.fr>
AntoineThebaud
force-pushed
the
antoinethebaud/cue-common-ds
branch
from
2f371b3 to
90baee1
Compare
jgbernalp
approved these changes
Jan 24, 2026
Nexucis
reviewed
Jan 26, 2026
| proxy: #HTTPProxy & { | ||
| kind: "HTTPProxy" | ||
| spec: { | ||
| url: "https://prometheus.demo.prometheus.io" |
Member
There was a problem hiding this comment.
I don't get why you are adding default value here.
Specially considering this is supposed to be used for datasource like Pyroscope. The allowedEndpoints list does not match the spec of Pyroscope.
Contributor
Author
There was a problem hiding this comment.
this is a test file ;)
Member
There was a problem hiding this comment.
oh ... right, sorry about that. LGTM then
Nexucis
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide new utilities corresponding to standard patterns observed on datasource plugins side. See the PR on /plugins side that will leverage this to see how that will simplify datasource schemas.
NB: I added some tests & had to adapt test-cue.go because the old behavior was too simplistic (it couldn't validate files that involved imports or definitions coming from other files of the same package)
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.