[BUGFIX] Prometheus: Propagate headers to the @prometheus-io/codemirror-promql package#79
[BUGFIX] Prometheus: Propagate headers to the @prometheus-io/codemirror-promql package#79th3M1ke wants to merge 1 commit intoperses:mainfrom
Conversation
…or-promql package Signed-off-by: Mykhailo Semenchenko <mike.semenchenko@gmail.com>
d6c4d86 to
17b054f
Compare
|
I don't see why do you need to implement the method |
|
Thanks for your feedback! 🙏 The method |
|
Oups sorry for the time it took to come back to you and thank you for pinging me on slack. So I would prefer to mock it for the moment. If at some points it's necessary we can finally implement it, it won't cost that much. On another topic, I don't get how this change can fix the issue you raised (#78). Propagating the headers is not the job of the plugin but the job of the proxy on the backend side. So this fill weird this PR is fixing that. Finally, can you
Thanks ! |
This pull request introduces several enhancements and new features to the Prometheus client and its integration with CodeMirror. The most significant changes include adding support for fetching Prometheus server flags, creating a CodeMirror Prometheus client adapter, and updating various components to utilize the new adapter.
Enhancements and New Features:
Support for Prometheus Server Flags:
FlagsResponsetype toprometheus/src/model/api-types.ts.flagsmethod inPrometheusClientinterface and implemented it inprometheus/src/model/prometheus-client.ts. [1] [2]prometheus/src/plugins/prometheus-datasource.tsxto use the newflagsmethod. [1] [2]CodeMirror Prometheus Client Adapter:
createCodeMirrorPromClientfunction inprometheus/src/model/prometheus-client.codemirror-adapter.ts.PrometheusTimeSeriesQueryEditorto use the new CodeMirror Prometheus client. [1] [2] [3]PrometheusPromQLVariableEditorto use the new CodeMirror Prometheus client. [1] [2] [3]Resolves: #78