Skip to content

[Snyk] Fix for 2 vulnerabilities #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patinthehat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
],
"devDependencies": {
"@biomejs/biome": "^1.5.3",
"@happy-dom/jest-environment": "^13.3.8",
"@happy-dom/jest-environment": "^20.0.0",
Copy link

@amazon-q-developer amazon-q-developer bot Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Security Fix Approved: This upgrade addresses two critical security vulnerabilities in happy-dom. The version jump from 13.x to 20.x is significant but necessary to resolve the Arbitrary Code Injection (CWE-94) and Prototype Pollution (CWE-1321) vulnerabilities12. Both packages are upgraded consistently, which maintains compatibility between happy-dom and @happy-dom/jest-environment.

Footnotes

  1. CWE-94: Arbitrary Code Injection - https://cwe.mitre.org/data/definitions/94.html ↩

  2. CWE-1321: Prototype Pollution - https://cwe.mitre.org/data/definitions/1321.html ↩

"@testing-library/jest-dom": "^6.4.1",
"@testing-library/react": "^14.2.1",
"@types/jest": "^29.5.12",
Expand All @@ -44,7 +44,7 @@
"eslint-plugin-jest": "^27.6.3",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-react": "^7.33.2",
"happy-dom": "^13.3.8",
"happy-dom": "^20.0.2",
Copy link

@amazon-q-developer amazon-q-developer bot Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Breaking Change Consideration: This is a major version upgrade (13.x → 20.x) that may introduce breaking changes. After merging, ensure all tests pass and verify that the Jest environment still functions correctly with your existing test suite. The upgrade is necessary for security but should be validated thoroughly.

"husky": "^9.0.10",
"jest": "^29.7.0",
"jsdom": "^24.0.0",
Expand Down
Loading