Skip to content

Fix ArgumentConverter JSON Formatting Indendation Bug #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patinthehat merged 8 commits into from
Feb 28, 2026
Merged

Fix ArgumentConverter JSON Formatting Indendation Bug #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b90adfd
feat(tests/ArgumentConverter.test.ts): add failing test for JSON form…
knightspore Feb 27, 2026
dbf16fe
fix(src/ArgumentConverter.ts): use correct indent type for prettyForm…
knightspore Feb 27, 2026
927991e
chore(tests/__snapshots__): update snapshots
knightspore Feb 27, 2026
8722d1c
fix(tests/ArgumentConverter.test.ts): typo
knightspore Feb 27, 2026
35cb0be
refactor(ArgumentConverter.test.ts): add decimal value to json -> htm…
knightspore Feb 27, 2026
18980de
chore(Ray.test.ts.snap): update snapshot
knightspore Feb 28, 2026
7138723
Update tests/ArgumentConverter.test.ts
knightspore Feb 28, 2026
e968095
Merge branch 'main' into fix-argument-converter-json-formatting-inden…
patinthehat Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ArgumentConverter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export class ArgumentConverter {
}

public static prettyFormatForHtml(arg: any): string {
const formatted = prettyFormat(arg, { indent: ' ' } as any)
const formatted = prettyFormat(arg, { indent: 4 })
// format whitespace for display in html
.replaceAll(' ', ' ')
.replace(/\r\n|\r|\n/g, '<br>')
Expand Down
11 changes: 11 additions & 0 deletions tests/ArgumentConverter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,14 @@ it('convert to primitive with a null argument', () => {
expect(result.value).toBeNull();
expect(result.isHtml).toBe(false);
});

// Tests that convertToPrimitive returns string value and isHtml property is true when an object or array argument is passed
it('converts array with decimal numbers to html correctly', () => {
const arg = ['foo', 'bar', 123, 0.123, { A: 123 }, null];
const result = ArgumentConverter.convertToPrimitive(arg);

expect(result.value).toBe(
'<code style="font-size: 0.8rem!important;" class=""><code style="font-size: 0.8rem!important;" class="bold text-gray-500 p-0">&nbsp;<span style="font-size: 0.8rem!important;" class="bold text-orange-400">[</span><br>&nbsp;&nbsp;&nbsp;&nbsp;<code style="font-size: 0.8rem!important;" class="bold text-green-600 p-0">"foo"</code><span style="font-size: 0.8rem!important;" class="bold text-orange-400">,</span><br>&nbsp;&nbsp;&nbsp;&nbsp;<code style="font-size: 0.8rem!important;" class="bold text-green-600 p-0">"bar"</code><span style="font-size: 0.8rem!important;" class="bold text-orange-400">,</span><br>&nbsp;&nbsp;&nbsp;&nbsp;123<span style="font-size: 0.8rem!important;" class="bold text-orange-400">,</span><br>&nbsp;&nbsp;&nbsp;&nbsp;0.123<span style="font-size: 0.8rem!important;" class="bold text-orange-400">,</span><br>&nbsp;&nbsp;&nbsp;&nbsp;<span style="font-size: 0.8rem!important;" class="bold text-yellow-600">Object</span>&nbsp;<code style="font-size: 0.8rem!important;" class="text-gray-600"><span style="font-size: 0.8rem!important;" class="bold text-orange-400">{</span><br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<code style="font-size: 0.8rem!important;" class="bold text-green-600 p-0">"A"</code><span style="font-size: 0.8rem!important;" class="bold text-orange-400">:&nbsp;</span>123<span style="font-size: 0.8rem!important;" class="bold text-orange-400">,</span><br>&nbsp;&nbsp;&nbsp;&nbsp;<span style="font-size: 0.8rem!important;" class="bold text-orange-400">}</span></code><span style="font-size: 0.8rem!important;" class="bold text-orange-400">,</span><br>&nbsp;&nbsp;&nbsp;&nbsp;<span style="font-size: 0.8rem!important;" class="bold text-indigo-600">null</span><span style="font-size: 0.8rem!important;" class="bold text-orange-400">,</span><br><span style="font-size: 0.8rem!important;" class="bold text-orange-400">]</span></code></code>',
);
expect(result.isHtml).toBe(true);
});
Loading
Loading