fix: Declare missing @percy/client dependency in cli-exec for Yarn PnP#2154
Open
akshayminocha5 wants to merge 1 commit intomasterfrom
Open
fix: Declare missing @percy/client dependency in cli-exec for Yarn PnP#2154akshayminocha5 wants to merge 1 commit intomasterfrom
akshayminocha5 wants to merge 1 commit intomasterfrom
Conversation
@percy/cli-exec imports @percy/client/utils (waitForTimeout) but did not declare @percy/client as a dependency. This breaks Yarn PnP which enforces strict dependency resolution. Also removes unused @percy/sdk-utils from @percy/monitoring. Closes #1612 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rishigupta1599
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@percy/clientas a declared dependency in@percy/cli-exec/package.json— it was already imported (waitForTimeoutfrom@percy/client/utils) but not declared, breaking Yarn PnP strict resolution@percy/sdk-utilsfrom@percy/monitoring/package.json— declared but never imported in any source fileRoot Cause
Yarn workspaces hoist dependencies to the root
node_modules, so the missing declaration worked in traditional npm/yarn. Yarn PnP enforces strict resolution where each package can only see its own declared dependencies, causing:Testing
@percy/cli-exectests: 33/33 pass@percy/monitoringtests: 40/40 passPost-Deploy Monitoring & Validation
No additional operational monitoring required: this is a package.json metadata-only change with no runtime behavior change — it makes an already-used dependency explicitly declared.
Closes #1612
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com