Skip to content

fix: Instructions external link to open in new tab #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tammy-a11y wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Instructions external link to open in new tab #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/angular-sdk-components/src/lib/_helpers/template-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,24 @@ export class TemplateUtils {
// The raw metadata for `instructions` will be something like '@PARAGRAPH .SomeParagraphRule' but
// it is evaluated by core logic to the content
if (instructions !== 'casestep' && instructions !== 'none') {
// if the instructions contains a link, and the link is external, add a target attribute to open in a new window
if (instructions.includes('<a')) {
const parser = new DOMParser();
const htmlDoc = parser.parseFromString(instructions, 'text/html');
const anchorNode = htmlDoc.querySelector('a');
if (anchorNode) {
try {
const url = new URL(anchorNode.href);
if (url.origin !== window.location.origin) {
anchorNode.setAttribute('target', '_blank');
anchorNode.setAttribute('rel', 'noopener');
return htmlDoc.body.innerHTML;
}
} catch (e) {
console.error(e);
}
}
}
return instructions;
}
return undefined;
Expand Down