Ensure all modules compile and target SDK 35 #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhosNickDoglio
force-pushed
the
ndoglio/sdk35
branch
from
64632f6 to
747511b
Compare
hellcp
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #338 I ran into a some compilation issues when trying to run detekt on the whole codebase as certain modules were trying to use dependencies that compiled with SDK 35 (Androidx.core-ktx and WorkManager) despite themselves not compiling/targeting SDK 35. The App module already compiles/targets SDK 35 so this shouldn't have any functional changes it just alleviates a build issue.