Run unit tests on CI #337
Merged
Run unit tests on CI #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhosNickDoglio
force-pushed
the
ndoglio/run-tests-ci
branch
5 times, most recently
from
f1f7811 to
d334704
Compare
WhosNickDoglio
force-pushed
the
ndoglio/run-tests-ci
branch
2 times, most recently
from
f3f58a7 to
6b8d834
Compare
WhosNickDoglio
force-pushed
the
ndoglio/run-tests-ci
branch
from
6b8d834 to
ef34007
Compare
hellcp
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much ready! There's a couple of things that will need to merge first (#319 and #339) before we can merge this.
I also need a maintainer to set the
GITHUB_ACTORandGITHUB_TOKENenvironment variables so we can pull the libpebblecommon dependency as we're currently failing with this errorSet github username and token in local.properties! (GITHUB_ACTOR and GITHUB_TOKEN)We could also work to publish libpebblecommon to Maven Central and I'd be happy to help with that 👍Open question:
Should I add this to all the CI workflows? or are we fine with just adding it to
pull-androidfor now?